[Midnightbsd-cvs] [MidnightBSD/mports] 222928: x11-toolkits, devel, www, etc: stop leaving .bak f...

[Lucas Holt]

  Branch: refs/heads/qt5-cmake-bak-cleanup
  Home:   https://github.com/MidnightBSD/mports
  Commit: 222928cd0498deef291995a911809f7ef2675c84
      https://github.com/MidnightBSD/mports/commit/222928cd0498deef291995a911809f7ef2675c84
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-05 (Sat, 05 Sep 2026)

  Changed paths:
    M accessibility/qt5-speech/Makefile
    M comms/qt5-sensors/Makefile
    M devel/qt5-core/Makefile
    M devel/qt5-dbus/Makefile
    M devel/qt5-designer/Makefile
    M devel/qt5-linguist/Makefile
    M devel/qt5-linguisttools/Makefile
    M devel/qt5-location/Makefile
    M devel/qt5-uitools/Makefile
    M graphics/qt5-svg/Makefile
    M graphics/qt5-wayland/Makefile
    M multimedia/qt5-multimedia/Makefile
    M net/qt5-network/Makefile
    M net/qt5-networkauth/Makefile
    M textproc/qt5-xmlpatterns/Makefile
    M www/qt5-webchannel/Makefile
    M www/qt5-webengine/Makefile
    M www/qt5-websockets/Makefile
    M x11-toolkits/qt5-charts/Makefile
    M x11-toolkits/qt5-datavis3d/Makefile
    M x11-toolkits/qt5-declarative-test/Makefile
    M x11-toolkits/qt5-declarative/Makefile
    M x11-toolkits/qt5-gamepad/Makefile
    M x11-toolkits/qt5-quick3d/Makefile
    M x11-toolkits/qt5-quickcontrols/Makefile
    M x11-toolkits/qt5-quickcontrols2/Makefile
    M x11-toolkits/qt5-uiplugin/Makefile
    M x11-toolkits/qt5-virtualkeyboard/Makefile
    M x11-toolkits/qt5-widgets/Makefile
    M x11/qt5-x11extras/Makefile

  Log Message:
  -----------
  x11-toolkits, devel, www, etc: stop leaving .bak files in the qt5 stage dir

Thirty qt5 ports rewrite the cmake config files they install with

	${REINPLACE_CMD} 's|/../../../../|/../../../|g' \
		${PREFIX}/lib/cmake/Qt5*/Qt5*Config.cmake

in post-install.  REINPLACE_CMD is `sed -i.bak`, and during fake
${PREFIX} already includes ${FAKE_DESTDIR}, so every one of these left a
Qt5*Config.cmake.bak next to the file it edited, inside the stage
directory.

The .bak files are not in pkg-plist and so were never packaged, but they
did make `bmake check-fake` print a missing-from-plist line for each one.
Across the tree that was around forty lines of noise, which is enough to
bury a real packing list error -- it is what hid the missing sdl2 backend
plugin in x11-toolkits/qt5-gamepad.

Use `${SED} -i ''` instead, which is already used elsewhere in the tree.
The rewrite itself is unchanged.

No PORTREVISION bumps: the packages are byte-identical.  For
graphics/qt5-svg the resulting Qt5SvgConfig.cmake was diffed against the
one produced by the REINPLACE_CMD version and is the same file; only the
.bak side effect is gone.

Verified on amd64 across the three shapes this line takes:
- glob target (graphics/qt5-svg): no .bak staged, no /../../../../ left
  in the output, check-fake now completely clean
- explicit single file (x11/qt5-x11extras): same
- leading `-` to ignore errors (x11-toolkits/qt5-quickcontrols): this
  port installs no cmake config files at all, so sed still fails and the
  `-` still swallows it; the build exits 0 as before

AI-Assisted-by: Claude Opus 5 (1M context) <noreply at anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
Claude-Session: https://claude.ai/code/session_01RfjmwisLNPFuZeaQCUJn4A
Signed-off-by: Lucas Holt <luke at foolishgames.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications