[Midnightbsd-cvs] [MidnightBSD/src] 6f9108: checkstyle9.pl: implement --github and make the st...

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/src
  Commit: 6f9108176ccaf0d4585f37c4edb77fcc86956693
      https://github.com/MidnightBSD/src/commit/6f9108176ccaf0d4585f37c4edb77fcc86956693
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-29 (Tue, 29 Sep 2026)

  Changed paths:
    M .github/workflows/style.yml
    M CLAUDE.md
    M tools/build/checkstyle9.pl

  Log Message:
  -----------
  checkstyle9.pl: implement --github and make the style CI actually run (#529)

The Style Checker workflow passed --github to checkstyle9.pl, which the
script did not implement, and it filtered on a "main" branch while the
repository's default branch is "master", so it never ran at all.

Add a --github mode that emits GitHub Actions workflow-command
annotations (::error / ::warning with file and line) so findings show
inline on the pull request.  The script already exits non-zero on
ERROR findings, which fails the job.

While here:
- resolve the source tree root after option parsing, which fixes the
  "Use of uninitialized value $root" warnings in --branch and --patch
  mode, and document --root / --no-tree;
- honour --color=never for the experimental-code banner;
- skip contrib/, crypto/ and sys/contrib/ since vendor code keeps its
  upstream style.

The workflow now checks the combined diff of the pull request with
--patch instead of each commit with --branch: paths are tree-relative
so the vendor skip applies, and line numbers match the head tree,
which is what the annotations need.  CLAUDE.md documents the real
command.

Fixes #528

AI-Assisted-by: Claude Fable 5.1

Signed-off-by: Lucas Holt <luke at foolishgames.com>
Co-authored-by: Claude Fable 5.1 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/src/settings/notifications