[Midnightbsd-cvs] [MidnightBSD/mports] a12d2f: lang/ghc: run bootstrap bindist install with a cle...

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: a12d2f88588d1e28884aaa3496964a47c0a207e9
      https://github.com/MidnightBSD/mports/commit/a12d2f88588d1e28884aaa3496964a47c0a207e9
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-07 (Mon, 07 Sep 2026)

  Changed paths:
    M lang/ghc/Makefile

  Log Message:
  -----------
  lang/ghc: run bootstrap bindist install with a clean environment (#863)

Fixes #857.

When `lang/ghc` is built as a dependency, `do-depends.sh` invokes bmake
with `-DINSTALLS_DEPENDS`, and bmake exports `-D INSTALLS_DEPENDS` in
the `MAKEFLAGS` environment variable. gmake 4.4.1 parses `MAKEFLAGS` as
options and rejects `-D`, so the bootstrap bindist's `gmake install` in
`pre-configure` failed with `: invalid option -- D`. Building the port
directly worked because `MAKEFLAGS` was empty.

The existing `Mk/extensions/gmake.mk` guard (`MAKE_ENV+= MAKEFLAGS=`)
only covers framework-driven make invocations. This direct call now uses
`${SETENVI} ${WRK_ENV}`, matching the `binary-dist` targets later in the
file and FreeBSD's port.

Verification: `bmake -DINSTALLS_DEPENDS -DBATCH configure` completes,
and the bootstrap install lands `work/ghc-boot-install/bin/ghc-9.6.7`.
portlint: 0 fatal errors, warnings pre-existing.

Note: about 30 other ports call `${MAKE_CMD}` or `${GMAKE}` bare inside
their own targets and carry the same latent bug when built as
dependencies (e.g. textproc/uim, japanese/uim-anthy, www/chromium,
www/py-django42, emulators/qemu7, ftp/proftpd). Not addressed here.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01PqhJwxeUv8hz3u16y8tpUz

## Summary by Sourcery

Bug Fixes:
- Ensure the GHC bootstrap bindist installation runs with a clean
environment when the port is built as a dependency, preventing inherited
MAKEFLAGS from breaking gmake.

Signed-off-by: Lucas Holt <luke at foolishgames.com>
Co-authored-by: Claude Fable 5.1 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications