[Midnightbsd-cvs] [MidnightBSD/mports] 052f73: multimedia/gstreamer1-plugins*: refresh patches fo...

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: 052f732c395a0c469d59e2dd9c2aa47c975d9ff3
      https://github.com/MidnightBSD/mports/commit/052f732c395a0c469d59e2dd9c2aa47c975d9ff3
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-18 (Fri, 18 Sep 2026)

  Changed paths:
    A multimedia/gstreamer1-plugins-bad/files/patch-ext_svthevcenc_meson.build
    M multimedia/gstreamer1-plugins-bad/files/patch-ext_webrtcdsp_meson.build
    M multimedia/gstreamer1-plugins-bad/files/patch-gst-libs_gst_codecparsers_meson.build
    M multimedia/gstreamer1-plugins-bad/files/patch-gst-libs_gst_codecs_meson.build
    M multimedia/gstreamer1-plugins-bad/files/patch-gst-libs_gst_cuda_meson.build
    M multimedia/gstreamer1-plugins-bad/files/patch-meson.build
    M multimedia/gstreamer1-plugins-bad/files/patch-meson.options
    M multimedia/gstreamer1-plugins-good/files/patch-sys_v4l2_gstv4l2object.c
    M multimedia/gstreamer1-plugins-ugly/files/patch-meson.options
    M multimedia/gstreamer1-plugins/files/patch-ext_cdparanoia_gstcdparanoiasrc.c
    M multimedia/gstreamer1-plugins/files/patch-ext_pango_meson.build
    M multimedia/gstreamer1-plugins/files/patch-ext_vorbis_meson.build
    M multimedia/gstreamer1-plugins/files/patch-gst-libs_gst_allocators_meson.build
    M multimedia/gstreamer1-plugins/files/patch-meson.build
    M multimedia/gstreamer1-plugins/files/patch-meson.options

  Log Message:
  -----------
  multimedia/gstreamer1-plugins*: refresh patches for 1.28.6 (#1479)

The GStreamer stack was updated to 1.28.6 in 076a62e095, but several
patches kept their 1.26-era context. Most still applied with an offset;
one did not apply correctly.

## The bug

`patch-gst-libs_gst_codecs_meson.build` wraps the codecs library in `if
get_option('codecs').enabled()` and closes it with an `endif` at the end
of the file. The hunk header was still `@@ -99,3 +107,4 @@` against
1.28.6's `@@ -101,3 +109,4 @@`, so the closing `endif` landed in the
wrong place and left `meson.override_dependency()` outside the guard:

```
gst-libs/gst/codecs/meson.build:112:26: ERROR: Unknown variable "pkg_name".
```

`pkg_name` is only defined inside the block, so any build with codecs
disabled fails at configure. That broke three ports that build from the
gst-plugins-bad sources:

- `multimedia/gstreamer1-plugins-dts`
- `multimedia/gstreamer1-plugins-resindvd`
- `multimedia/gstreamer1-plugins-core`

## What changed

Refreshed 15 stale patches across `gstreamer1-plugins`, `-bad`, `-good`
and `-ugly` to the versions upstream carries for 1.28.6, and added
`patch-ext_svthevcenc_meson.build`.

Two are deliberately untouched:

| Patch | Why |
|---|---|
| `gstreamer1-plugins-bad/files/patch-gst-libs_gst_va_meson.build` |
Carries the mports-local addition of `midnightbsd` to the `host_system`
list. Otherwise current — same context and line numbers as upstream's. |
| `gstreamer1-plugins-bad/files/patch-ext_sctp_usrsctp_meson.build` |
mports-only, no upstream counterpart. |

## Validation

Every patch in all four ports was dry-run against the real 1.28.6
sources (`gst-plugins-base`, `-bad`, `-good`, `-ugly`) — all apply
cleanly, none with fuzz or offset.

`dts`, `resindvd` and `core` now build, package and install. All 23
GStreamer packages are at 1.28.6 on the test machine.

No version, dependency or plist changes — patches only.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01NSsgED5s7GPYJNb1HxuaU9

## Summary by Sourcery

Refresh the GStreamer plugin patches for 1.28.6 and restore successful
builds for ports using disabled codecs.

Bug Fixes:
- Fix GStreamer plugin configuration failures when codecs are disabled
by correcting refreshed Meson patch context.

Enhancements:
- Refresh the GStreamer 1.28.6 patches across the base, bad, good, and
ugly plugin ports and add the required SVT-HEVC encoder patch.

Tests:
- Verify that all patches apply cleanly to the 1.28.6 sources and that
the affected ports build, package, and install successfully.

Signed-off-by: Lucas Holt <luke at foolishgames.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications