[Midnightbsd-cvs] [MidnightBSD/mports] 9f3a3e: x11/libxkbcommon: fix version-script probe so symb...

[Lucas Holt]

  Branch: refs/heads/master
  Home:   https://github.com/MidnightBSD/mports
  Commit: 9f3a3e204a0f60b060d6be7fc1b364e450db0aad
      https://github.com/MidnightBSD/mports/commit/9f3a3e204a0f60b060d6be7fc1b364e450db0aad
  Author: Lucas Holt <luke at foolishgames.com>
  Date:   2026-09-23 (Wed, 23 Sep 2026)

  Changed paths:
    M x11/libxkbcommon/Makefile
    A x11/libxkbcommon/files/patch-meson.build

  Log Message:
  -----------
  x11/libxkbcommon: fix version-script probe so symbol versions are applied (#1611)

Fixes #1105.

## Root cause
Meson's `-Wl,--version-script` probe links an **executable** with a map
that localizes every symbol. On MidnightBSD (and FreeBSD) `crt1.o`
defines `environ` and `__progname` and `libc.so.7` references them, so
hiding them makes the link invalid. Both LLD 19.1.7 and GNU ld reject
it; this is not an LLD or CRT bug. The probe therefore reported
unsupported and the `V_*` project maps were silently dropped from all
three libraries.

## Fix
- `files/patch-meson.build`: link the probe with `-shared` (same patch
as FreeBSD ports).
- `HAS_SYMBOL_VERSION` on `libxkbregistry.so` so `fake-sanity` fails if
versions are ever dropped again.
- `PORTREVISION=1`, since installed libraries gain symbol versions.

## Verification
- `bmake fake` / `bmake package` succeed; probe now reports `YES`.
- `readelf -D -s` shows `@V_0.5.0` .. `@V_1.12.0` on `libxkbcommon.so`,
`@V_1.0.0`/`@V_1.11.0` on `libxkbregistry.so`.
- `portlint -A`: 0 fatal errors.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

## Summary by Sourcery

Restore symbol versions in the libxkbcommon port and add validation to
ensure they remain enabled.

Bug Fixes:
- Restore symbol versioning for libxkbcommon libraries by fixing the
Meson linker probe to support version scripts.

Enhancements:
- Add a symbol-version sanity check for libxkbregistry to prevent future
version scripts from being silently omitted.

Chores:
- Increment the port revision to reflect the newly versioned installed
libraries.

Signed-off-by: Lucas Holt <luke at foolishgames.com>
Co-authored-by: Claude Fable 5.1 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/MidnightBSD/mports/settings/notifications